In december 2020, self approval (approval by the author) has been removed and after a feature request been brought back after a few days. Apparently, a lot of teams were using self-approvals for various reasons in their daily workflows.
Although self-approval is back I currently see no way "as a reviewer" to see the approval of the author.
Background:
We use self-approval to indicate to the group that the PR is open to review. Before self-approval the PR is WIP and must not be considered by the group. Often, PR's are created way before they are released to the group for various reasons. E.g. comments are placed in the code as to why something has been done that way.
Acceptance criteria for us:
a) see the authors approval somewhere
or
b) have a WIP status of a PR (PR created but not officially open to review) as Gitlab it
Hi @Antonius Golly ,
While you are viewing a PR, the author's avatar shows below the PR title.
When the author approves the PR, a green check icon is displayed at the upper right corner of their avatar.
See the screenshots below, this is how it looks before author approval:
and after author approval:
Is this something that works for you? Please feel free to let me know if you have any questions.
Kind regards,
Theodora
@Theodora Boudale That was how it worked before. Unfortunately we couldn't reproduce it. We are going to check once more...
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.
Hi @Antonius Golly ,
Please feel free to let me know when you give it another try.
In case the issue persists, please let me know
i) what browser you are using, and which version
ii) whether the issue is reproducible in an Incognito/Private window of the same browser, with all extensions disabled
so we can see whether this may be affecting the issue.
Kind regards,
Theodora
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.