Hello,
our team uses Subversion as a source code repository and Crucible (2.10) for code reviews. We'd like to follow pre-commit code review approach using patches. However we found it's impossible to do iterative reviews, since every new patch creates separately, preventing us from viewing diffs between them. I read docs, researched it on this forum and web, however couldn't find an answer. The closest I found was: https://answers.atlassian.com/questions/11989164 , however they use Mercurial, which is different from SVN and doesn't work for us. Please assist here.
Hi Marat,
You can only anchor a patch to a repository if the content you are editing already exists in the repo. This means that anchored paths are not possible for newly created files.
You may refer to the Iterative Reviews document for further information on this.
Regards,
Gustavo Refosco
Hello Gustavo, here is the scenario: 1. File exist in a repo 2. Patch with changes is uploaded 3. Devs leaves comments and a new patch is uploaded to address those 4. A separate patch is created and it's not linked to a previous one anyhow. No iterations are created. Hence it is imposible to do pre-commit iterative code reviews as advised in the link you sent: https://confluence.atlassian.com/crucible/iterative-reviews-298977456.html#Iterativereviews-Iterativepre-commitreviews
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.
Did anyone ever figure this out? Someone here dropped a hundred-file review on me where I can't tell what changed from the previous hundred-file review, and I would rather not re-review all the code I have already reviewed as I could be using that time to do something useful instead. When I tried to follow the same procedure myself, I had exactly the same problem - it became a second unrelated diff with all the same paths in it as the first one, despite being anchored to exactly the same repo and path as the first one.
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.
Online forums and learning are now in one easy-to-use experience.
By continuing, you accept the updated Community Terms of Use and acknowledge the Privacy Policy. Your public name, photo, and achievements may be publicly visible and available in search engines.
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.